Add thread level to csv output.#35
Add thread level to csv output.#35julianedwards wants to merge 1 commit intofacebookarchive:masterfrom julianedwards:add-thread-level
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for your pull request. I am not sure that this repo has a maintainer, thus it was moved into github.com/facebookarchive and it might be read-only. My linkbench fork is still active at https://github.com/mdcallag/linkbench |
|
Mark,
Thanks for responding! Should I make the PR to your fork instead then?
Best,
Julian
…On Mon, Jun 18, 2018 at 1:47 PM, Mark Callaghan ***@***.***> wrote:
Thank you for your pull request. I am not sure that this repo has a
maintainer, thus it was moved into github.com/facebookarchive and it
might be read-only. My linkbench fork is still active at
https://github.com/mdcallag/linkbench
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APy5ACYKjbg-2QKza_pvFLPROWaoe3DPks5t9-eWgaJpZM4Um7IJ>
.
|
|
yes
On Mon, Jun 18, 2018 at 3:42 PM, julianedwards <notifications@github.com>
wrote:
… Mark,
Thanks for responding! Should I make the PR to your fork instead then?
Best,
Julian
On Mon, Jun 18, 2018 at 1:47 PM, Mark Callaghan ***@***.***>
wrote:
> Thank you for your pull request. I am not sure that this repo has a
> maintainer, thus it was moved into github.com/facebookarchive and it
> might be read-only. My linkbench fork is still active at
> https://github.com/mdcallag/linkbench
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/facebookarchive/linkbench/
pull/35#issuecomment-398138417>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/APy5ACYKjbg-2QKza_
pvFLPROWaoe3DPks5t9-eWgaJpZM4Um7IJ>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABkKTceeRu9tv0AGRQ_IFb-31zxLEUD4ks5t-CzfgaJpZM4Um7IJ>
.
--
Mark Callaghan
mdcallag@gmail.com
|
Hello,
I am an infrastructure engineer on the performance team at MongoDB and we are using Linkbench as part of our performance testing. After a Linkbench task is run, we need to parse the results and the thread levels used. It would be cleaner to have the thread levels in the csv file along with the results. I think this would be helpful to many users of Linkbench, and at the very least won't hurt them as it is backwards compatible.
Thanks,
Julian