This repository was archived by the owner on Sep 2, 2020. It is now read-only.
Fix logcat-json command to honor adb parameters#63
Open
lemon18 wants to merge 1 commit intofacebookarchive:masterfrom
Open
Fix logcat-json command to honor adb parameters#63lemon18 wants to merge 1 commit intofacebookarchive:masterfrom
lemon18 wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
Since adb parameters are not forwarded, options like -d/-e are not working and logcat-json refures to work when more than one device is connected at the same time
Contributor
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since adb parameters are not forwarded, options
like -d/-e are not working and logcat-json
refures to work when more than one device
is connected at the same time