Skip to content

Issue 4510 preprocessor var to always use all logical cores #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sergey-dryabzhinsky wants to merge 5 commits into
base: dev
Choose a base branch
from
+12 −1
Draft

Issue 4510 preprocessor var to always use all logical cores #4526

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f43df45
Merge pull request #1 from facebook/dev
sergey-dryabzhinsky Nov 5, 2025
43161ba
Update zstdcli.c
sergey-dryabzhinsky Nov 6, 2025
bfd85e3
Update zstdcli.c
sergey-dryabzhinsky Nov 6, 2025
a2ed94e
Merge pull request #2 from facebook/dev
sergey-dryabzhinsky Nov 25, 2025
508de21
Merge pull request #3 from sergey-dryabzhinsky/dev
sergey-dryabzhinsky Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion programs/zstdcli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
# define ZSTDCLI_CLEVEL_DEFAULT 3
#endif

#ifndef ZSTDCLI_AUTO_THREADING_LOGICAL
# define ZSTDCLI_AUTO_THREADING_LOGICAL 0
#endif

#ifndef ZSTDCLI_CLEVEL_MAX
# define ZSTDCLI_CLEVEL_MAX 19 /* without using --ultra */
#endif
Expand Down Expand Up @@ -237,7 +241,11 @@ static void usageAdvanced(const char* programName)
DISPLAYOUT(" -T# Spawn # compression threads. [Default: %u; pass 0 for core count.]\n", init_nbWorkers(ZSTDCLI_NBTHREADS_DEFAULT));
DISPLAYOUT(" --single-thread Share a single thread for I/O and compression (slightly different than `-T1`).\n");
DISPLAYOUT(" --auto-threads={physical|logical}\n");
DISPLAYOUT(" Use physical/logical cores when using `-T0`. [Default: Physical]\n\n");
#ifdef ZSTDCLI_AUTO_THREADING_LOGICAL
DISPLAYOUT(" Use physical/logical cores when using `-T0`. [Default: Logical ]\n\n");
#else
DISPLAYOUT(" Use physical/logical cores when using `-T0`. [Default: Physical ]\n\n");
#endif
DISPLAYOUT(" --jobsize=# Set job size to #. [Default: 0 (automatic)]\n");
DISPLAYOUT(" --rsyncable Compress using a rsync-friendly method (`--jobsize=#` sets unit size). \n");
DISPLAYOUT("\n");
Expand Down Expand Up @@ -1113,6 +1121,9 @@ int main(int argCount, const char* argv[])
defaultLogicalCores = 1;
continue;
}
#ifdef ZSTDCLI_AUTO_THREADING_LOGICAL
defaultLogicalCores = 1;
#endif
#ifdef UTIL_HAS_MIRRORFILELIST
if (longCommandWArg(&argument, "--output-dir-mirror")) {
NEXT_FIELD(outMirroredDirName);
Expand Down