[chore] downgrade yargs to v17 and bump baseline-browser-mapping to fix CLI tests #1451
+2,087
−1,989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellyeliu
requested review from
ezzak,
necolas,
nmn and
vincentriemer
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
mellyeliu
force-pushed
the
fix-cli-tests-yargs-clean
branch
from
d8018d5 to
28d50f6
Compare
Fixes CLI tests that were failing due to stderr output: 1. Yargs v18 is ESM-only but the CLI compiles to CommonJS, causing ERR_REQUIRE_ESM errors when running the CLI via child process. - Downgrade yargs from ^18.0.0 to ^17.7.2 in cli and scripts packages 2. baseline-browser-mapping was emitting a "data is over two months old" warning to stderr, which the tests treated as an error. - Add resolution to force baseline-browser-mapping to ^2.9.14
mellyeliu
force-pushed
the
fix-cli-tests-yargs-clean
branch
from
28d50f6 to
a2c386a
Compare
mellyeliu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix failing CLI tests on main