[DRAFT] db/blob: add direct <cstdint> include in blob_index.h (GCC 15)#14334
Draft
arup-chauhan wants to merge 1 commit intofacebook:mainfrom
Draft
[DRAFT] db/blob: add direct <cstdint> include in blob_index.h (GCC 15)#14334arup-chauhan wants to merge 1 commit intofacebook:mainfrom
arup-chauhan wants to merge 1 commit intofacebook:mainfrom
Conversation
Signed-off-by: Arup Chauhan <arupchauhan.connect@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR adds a direct
#include <cstdint>todb/blob/blob_index.h.Aim to fix #13365
blob_index.huses fixed-width integer types (e.g.uint64_t) and should be self-contained instead of relying on transitive includes.Why
GCC 15 is stricter in some include-order situations, and missing direct includes can surface as build failures in downstream consumers.
Change
db/blob/blob_index.h#include <cstdint>Validation
This is a minimal ownership patch to unblock progress and document direction; I can follow up with any additional missing
<cstdint>includes in other blob headers if maintainers prefer a broader fix in one PR.