windows + cmake + clang-cl: build all #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyan4973
force-pushed
the
windows_build_all
branch
from
15e8a7a to
62f078f
Compare
Contributor
Author
in an attempt to reproduce issues mentioned in facebook#96
(cherry picked from commit 747f78a)
Cyan4973
force-pushed
the
windows_build_all
branch
from
62f078f to
51017b7
Compare
Contributor
Author
|
added "missing STL includes" from #96 by @nathandelisle |
Contributor
Author
|
CI tests still fail, though that may now be related to #97 ? |
|
FWIW, on my Windows setup (VS2022 + clang-cl), #96 and #97 are sufficient for a clean build. in my view the #99 failures look orthogonal - exceptions are off (likely due to no /EHsc) so anything that uses throw/try errors. also there is a zstd RC failure, easy to fix by disabling zstd shared on Windows? |
Contributor
Author
|
OK, so let's work on integrating #97, and then we'll work our way towards the other remaining issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in an attempt to reproduce issues mentioned in #96