Pull PendingOp implementation and comparator from the ParserImpl #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91689034. |
Summary: This makes a little bit easier to understand how the code corresponds to different components of the compiler. Differential Revision: D91689013
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Jan 28, 2026
…ebook#351) Summary: Pull Request resolved: facebook#351 `parse_expr` is currently quite dense and difficult to follow. This diff aims to reduce the density by pulling the pending_op comparator logic out into the anonymous namespace. Differential Revision: D91689034
daniellerozenblit
force-pushed
the
export-D91689034
branch
from
d7af22a to
ec0b4d3
Compare
facebook#351) Summary: Pull Request resolved: facebook#351 `parse_expr` is currently quite dense and difficult to follow. This diff aims to reduce the density by pulling the pending_op comparator logic out into the anonymous namespace. Differential Revision: D91689034
daniellerozenblit
force-pushed
the
export-D91689034
branch
from
ec0b4d3 to
32c45f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
parse_expris currently quite dense and difficult to follow. This diff aims to reduce the density by pulling the pending_op comparator logic out into the anonymous namespace.Differential Revision: D91689034