Fix -Wtypedef-redefinition errors in public headers for C99 compatibility
#293
+0
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove duplicate typedef definitions in
zl_graph_api.hthat cause compilation errors when external projects include OpenZL headers with C99 mode and-Werror -Wtypedef-redefinition.Before this fix, compiling with C99 produced:
Type of Change
Bug fix (non-breaking change which fixes an issue)
Test Plan
Prepare: Build OpenZL and install
Verify C99 compilation works with installed headers
Confirm that including OpenZL headers compiles without errors in C99 mode with
-Werror -Wtypedef-redefinition.clang -std=c99 -Werror -Wtypedef-redefinition \ -I/tmp/local/include \ -c /tmp/test.c -o /tmp/test.oRun all tests
Verify no regressions:
ctest(1202 tests passed)Test Configuration