Add OPENZL_USE_SYSTEM_ZSTD option to use system-installed zstd #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary GitHub: GH-facebook#105 Add a new CMake option `OPENZL_USE_SYSTEM_ZSTD` that allows using system-installed zstd library via `find_package(zstd CONFIG)` instead of the bundled version. This is useful for Linux distributions that package zstd separately. When enabled: - Uses `find_package(zstd CONFIG REQUIRED)` to find system zstd - Creates a `libzstd` alias target for compatibility with existing code - Exported config includes `find_dependency(zstd)` for downstream projects When disabled (default): - Behavior unchanged (uses git submodule or FetchContent) ## Type of Change New feature (non-breaking change which adds functionality) ## Test Plan ### Build with system zstd ```console cmake \ -S .\ -B ../openzl.build \ -DOPENZL_USE_SYSTEM_ZSTD=ON \ -DOPENZL_BUILD_TESTS=ON \ -DCMAKE_INSTALL_PREFIX=/tmp/local &&\ cmake --build ../openzl.build -j4 &&\ ctest --test-dir ../openzl.build --output-on-failure ``` ### Verify installation does not include zstd files ```console cmake --install ../openzl.build ls /tmp/local/lib/ | grep libzstd # should be empty ``` ### Build with bundled zstd (default) ```console cmake \ -S . \ -B ../openzl.build \ -DOPENZL_BUILD_TESTS=ON \ -DCMAKE_INSTALL_PREFIX=/tmp/local &&\ cmake --build openzl.build -j4 &&\ ctest --test-dir ../openzl.build --output-on-failure ``` ### Verify installation includes zstd files ```console cmake --install ../openzl.build ls /tmp/local/lib/ | grep libzstd libzstd.a libzstd.so libzstd.so.1 libzstd.so.1.5.7 ``` ### Test Configuration - Compiler: GCC 13.3.0 - Build type: default - Platform: Linux (Ubuntu)
otegami
force-pushed
the
use-system-zstd
branch
from
efd9510 to
278d5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #105
Add a new CMake option
OPENZL_USE_SYSTEM_ZSTDthatallows using system-installed zstd library via
find_package(zstd CONFIG)instead of the bundledversion. This is useful for Linux distributions that
package zstd separately.
When enabled:
find_package(zstd CONFIG REQUIRED)to find system zstdlibzstdalias target for compatibility with existing codefind_dependency(zstd)for downstream projectsWhen disabled (default):
Type of Change
New feature (non-breaking change which adds functionality)
Test Plan
Build with system zstd
Verify installation does not include zstd files
Build with bundled zstd (default)
Verify installation includes zstd files
Test Configuration