Skip to content

Conversation

@njmei
Copy link

@njmei njmei commented Oct 14, 2025

Summary

This PR modifies the version field for the Python wrapper package of OpenZl by making it dynamic. The version values will now be obtained from the include/openzl/zl_version.h file.

Type of Change

Build/CI changes (update how version of pyproject.toml is set)

Test Plan

Validation:

  • On local copy, modified ZL_LIBRARY_VERSION_PATCH from 0 -> 1
  • Ran pip install
  • Confirmed version now reflects values in zl_version.h

Output:

> pip install .
Processing /data/openzl/py
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: openzl
  Building wheel for openzl (pyproject.toml) ... done
  Created wheel for openzl: filename=openzl-0.1.1.dev0-cp312-abi3-linux_x86_64.whl size=5683742 sha256=3169b521b1aafffb437201597f1575e443ff7c7a6db83555ba08dc5dbbc7dfa4
  Stored in directory: /tmp/pip-ephem-wheel-cache-fg9ff8b8/wheels/a7/2d/36/abbf0c966eef96fc386ad984a19e8201825d1f42816b0e0a7d
Successfully built openzl
Installing collected packages: openzl
Successfully installed openzl-0.1.1.dev0

Test Configuration

Not really relevant

This commit modifies the version field for the Python wrapper package
of OpenZl by making it dynamic. The version values will now be
obtained from the `include/openzl/zl_version.h` file.

Validation:

- On local copy, modified `ZL_LIBRARY_VERSION_PATCH` from 0 -> 1
- Ran pip install
- Confirmed version now reflects values in `zl_version.h`
@meta-cla
Copy link

meta-cla bot commented Oct 14, 2025

Hi @njmei!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@njmei
Copy link
Author

njmei commented Oct 14, 2025

Looks like I hadn't signed the CLA yet, I've done that now.

@Cyan4973 Cyan4973 requested a review from terrelln October 14, 2025 19:04
@meta-cla meta-cla bot added the cla signed label Oct 14, 2025
@meta-cla
Copy link

meta-cla bot commented Oct 14, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant