Skip to content

Refactored History into its own plugin#30

Open
amyworrall wants to merge 1 commit intomainfrom
pr30
Open

Refactored History into its own plugin#30
amyworrall wants to merge 1 commit intomainfrom
pr30

Conversation

@amyworrall
Copy link
Contributor

Refactored History into its own plugin

@amyworrall
Copy link
Contributor Author

Notes:

  • History (i.e. undo/redo) is now inside its own plugin, which is in turn inside its own library
  • The playground now supports undo/redo
  • In order to fit the new buttons on the playground toolbar, I had to refactor things a bit, bringing the styling (i.e. bold, italic etc) buttons into a popup menu.
  • LexicalView no longer provides an EditorHistory object. It was confusing before, because that is only one part of what is required to implement undo/redo, so its presence might have suggested to developers that they didn't need to do any extra work. With the new system, where undo/redo is provided by a plugin, developers genuinely don't need to do any extra work, apart from writing the UI for the buttons that expose undo/redo to the user!

@facebook-github-bot
Copy link
Contributor

@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@amyworrall amyworrall linked an issue Jul 12, 2023 that may be closed by this pull request
@facebook-github-bot
Copy link
Contributor

Hi @amyworrall!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor undo/redo and integrate with playground

2 participants