Skip to content

Conversation

@rubu
Copy link

@rubu rubu commented Jun 2, 2025

Motivation

I need to run idb in a node native addon thus there is nothing to drive the main queue which is used under the hood. This PR seems to allow me to boot a device and receive the callbacks by providing custom async/work queues via FBSimulatorControlConfiguration. I tried to make this an opt in behaviour - the new properties are default nil and have a designated initializer and internally the work/async queues use the old values if these configuration values are not specified.

Test Plan

Testing is something i wanted some feedback on. So obviously:

  1. using the existing configuration should not change any tests since as i mentioned this should be opt in
  2. tests also use dispatch_get_main_queue() which would then need to be adjusted - as in the tests should then use a given queue (most likely each test should be run with main and with a custom queue?), provide it to the frameworks via the configuration and expect everything to work. Is that the route that should be taken here?

@facebook-github-bot
Copy link

Hi @rubu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@rubu rubu force-pushed the allow-using-custom-queues branch from 146243c to 0e9a926 Compare June 25, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants