wedge800bact: platform: Switch MCB_PWRBRK_MONITOR to tda38640 #770
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit run$ pre-commit run --files fboss/platform/configs/wedge800bact/platform_manager.json fboss/platform/configs/wedge800bact/sensor_service.json
clang-format.........................................(no files to check)Skipped
black................................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
Summary:
Update MCB_PWRBRK_MONITOR to use the tda38640 PMBus driver instead of xdpe15284, and align the sensor_service sysfs paths accordingly.
Based on vendor recommendation, tda38640 is a better fit for the power brick Q54SW120A7 because:
Changes:
Test Plan:
platform_manager.log
sensor_service.log
sensor_service_client.log
platform_manager_hw_test.log
sensor_service_hw_test.log