Skip to content

Conversation

@brandonchuang
Copy link
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    $ pre-commit run --files fboss/platform/configs/wedge800bact/platform_manager.json fboss/platform/configs/wedge800bact/sensor_service.json
    clang-format.........................................(no files to check)Skipped
    black................................................(no files to check)Skipped
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...............................................................Passed
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped

Summary:

Update MCB_PWRBRK_MONITOR to use the tda38640 PMBus driver instead of xdpe15284, and align the sensor_service sysfs paths accordingly.

Based on vendor recommendation, tda38640 is a better fit for the power brick Q54SW120A7 because:

  • Q54SW120A7 only operates on page 0.
  • tda38640 is designed as a single-page PMBus device.
  • Using a single-page driver provides a more stable and consistent integration with the hardware behavior.

Changes:

  • platform_manager.json
    • Update MCB_PWRBRK_MONITOR kernelDeviceName from xdpe15284 to tda38640.
  • sensor_service.json
    • Update VOUT sensor path from in3_input to in2_input.
    • Update IOUT sensor path from curr3_input to curr2_input.

Test Plan:

Summary:
Update MCB_PWRBRK_MONITOR to use the tda38640 PMBus driver instead of xdpe15284,
and align the sensor_service sysfs paths accordingly.

Based on vendor recommendation, tda38640 is a better fit for the power brick
Q54SW120A7 because:
- Q54SW120A7 only operates on page 0.
- tda38640 is designed as a single-page PMBus device.
- Using a single-page driver provides a more stable and consistent integration
  with the hardware behavior.

Changes:
- platform_manager.json
  - Update MCB_PWRBRK_MONITOR kernelDeviceName from xdpe15284 to tda38640.
- sensor_service.json
  - Update VOUT sensor path from in3_input to in2_input.
  - Update IOUT sensor path from curr3_input to curr2_input.

Test Plan:
- Compilation and configuration validation completed successfully.
- On Wedge800BACT device:
  - platform_manager starts and runs normally.
    [platform_manager.log](https://github.com/user-attachments/files/24325378/platform_manager.log)
  - sensor_service starts normally and all sensors are correctly discovered.
    [sensor_service.log](https://github.com/user-attachments/files/24325380/sensor_service.log)
  - sensor_service_client: all test cases passed.
    [sensor_service_client.log](https://github.com/user-attachments/files/24325381/sensor_service_client.log)
- Executed platform_manager_hw_test and sensor_service_hw_test;
  all test cases passed.
    [platform_manager_hw_test.log](https://github.com/user-attachments/files/24325379/platform_manager_hw_test.log)
    [sensor_service_hw_test.log](https://github.com/user-attachments/files/24325382/sensor_service_hw_test.log)
@meta-cla meta-cla bot added the CLA Signed label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant