[Nexthop] Split FBOSS packaging #765
Open
+192
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary
======
Split the single package into five packages based on three targets:
forwarding-stack: The forwarding stack and files necessary for
execution
platform-stack: The platform stack and supporting files
agent-benchmarks: The agent benchmark HW tests
The platform-stack and forwarding-stack targets have a production
archive and a -test archive which contains the tests and utility files
for that component.
This is necessary so we can install the Platform Stack and Forwarding
Stack at different times in the Distro Image. Further, we don't want
to install the tests in the Distro Image which is supposed to
represent a production-like environment.
This does slightly less than package-fboss.py which copies several
unnecessary files (such as .a library archives) and attempts to
dynamically package library dependencies from the build container. We
don't want the former files installed into the Distro Image and the
latter libraries are currently being put into the Distro Image in
another way.
Test Plan
=========
Inside the build container, run both package.py for all three targets
and manually verify that each produces the matching tar files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Split the single package into five packages based on three targets:
forwarding-stack: The forwarding stack and files necessary for execution
platform-stack: The platform stack and supporting files
agent-benchmarks: The agent benchmark HW tests
The platform-stack and forwarding-stack targets have a production archive and a -test archive which contains the tests and utility files for that component.
This is necessary so we can install the Platform Stack and Forwarding Stack at different times in the Distro Image. Further, we don't want to install the tests in the Distro Image which is supposed to represent a production-like environment.
This does slightly less than package-fboss.py which copies several unnecessary files (such as .a library archives) and attempts to dynamically package library dependencies from the build container. We don't want the former files installed into the Distro Image and the latter libraries are currently being put into the Distro Image in another way.
Also this script does not support compressing the archives because the archives are intended as intermediate artifacts which are shortly consumed by a Distro Image build. Compressing these outputs prior to publishing as reference artifacts is the responsibility of a different, yet to be written, component.
Test Plan
Inside the build container, run both package.py for all three targets and manually verify that each produces the matching tar files.