[Nexthop][fboss2-dev] Add a utility class to help map ports to interfaces. #755
Conversation
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part03
branch
from
04bd218 to
ab2a9fb
Compare
joseph5wu
left a comment
joseph5wu
left a comment
There was a problem hiding this comment.
Overall it looks pretty good to me. Please address the two main comments:
- Removing vlog
- Use fboss strong type for the ids
fboss/cli/fboss2/utils/PortMap.h
Outdated
| * @param portName The name of the port (e.g., "eth1/20/1") | ||
| * @return The interface ID if found, std::nullopt otherwise | ||
| */ | ||
| std::optional<int32_t> getInterfaceIdForPort( |
There was a problem hiding this comment.
Can we use FBOSS_STRONG_TYPE from https://github.com/facebook/fboss/blob/main/fboss/agent/types.h#L74
like we do in
https://github.com/facebook/fboss/blob/main/fboss/agent/ApplyThriftConfig.cpp#L674
Please update all the int32_t to the corresponding PortID or InterfaceID from this types.h
| } | ||
|
|
||
| VLOG(2) << "Built port maps with " << portNameToLogicalId_.size() << " ports"; | ||
| } |
There was a problem hiding this comment.
Will vlog dump this logging to the final output of your CLI?
We usually don't use vlog in fboss but xlog from folly.
If you don't need this logging, I'd suggest to remove it cause this is cli tool.
There was a problem hiding this comment.
By default it's not visible in the output of the CLI, no, unless you turn on verbose logging.
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part03
branch
from
ab2a9fb to
1e8d134
Compare
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part03
branch
3 times, most recently
from
3038f6a to
7a586bc
Compare
Sample output: ``` Config Applied Information: =========================== Last Applied Time: 2025-10-11 09:29:36.589 Last Coldboot Applied Time: 2025-10-11 06:44:36.741 ```
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part03
branch
from
7a586bc to
4102813
Compare
2 participants
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This is a small helper class used to lookup ports and interfaces in a consistent fashion in CLI commands.
Note: this change is part of a series, the previous one is #754, the next one is #756.
Test Plan
Unit tests.