Skip to content

Conversation

@pabloyangWW
Copy link
Contributor

…orrect HSC current/power scaling

[Task Description]
Modify BIC (Server Board) temperature sensor thresholds and adjust HSC r_sense scaling to correct HSC current/power calculation.

[Motivation]

  • Update and unify BIC temperature thresholds to match thermal policy and the management spreadsheet.
  • Ensure HSC current/power measurements are correctly scaled by adjusting HSC r_sense to match actual hardware shunt/calibration.
  • Provide verified sensor logs for BIC thermal and HSC power sensors.

[Design]
Update BIC (Server Board) sensor thresholds:

  • MB_PCH_TEMP_C (0x04)

    • UCR = 71°C
  • MB_SOC_CPU_TEMP_C (0x05)

    • UCR = 75°C
    • UNR = 78°C
  • MB_DIMMA2_TEMP_C (0x06), MB_DIMMA3_TEMP_C (0x07), MB_DIMMA6_TEMP_C (0x0A), MB_DIMMA7_TEMP_C (0x0B)

    • UCR = 85°C
  • MB_E1S_TEMP_C (0x0D)

    • UCR = 70°C

HSC related scaling:

  • Adjust HSC r_sense from 0.25 -> 1
    • Purpose: correct current/power scaling used by the driver so HSC current/power sensors report accurate values that match hardware calibration/shunt configuration.

[Test Result]
Verified on GC2-ES platform using sensor-util. BIC related sensor outputs:

root@bmc-oob:~# sensor-util server --threshold | grep MB_PCH_TEMP_C
MB_PCH_TEMP_C (0x4) : 35.000 C | (ok) | UCR: 71.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep MB_SOC_CPU_TEMP_C
MB_SOC_CPU_TEMP_C (0x5) : 33.000 C | (ok) | UCR: 75.000 | UNC: NA | UNR: 78.000 | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep DIMM | grep TEMP
MB_DIMMA2_TEMP_C (0x6) : 32.000 C | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
MB_DIMMA3_TEMP_C (0x7) : 31.000 C | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
MB_DIMMA6_TEMP_C (0xA) : 32.000 C | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
MB_DIMMA7_TEMP_C (0xB) : 32.000 C | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep MB_E1S_TEMP_C
MB_E1S_TEMP_C (0xD) : 32.000 C | (ok) | UCR: 70.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

HSC power/current sensors (added as verification): root@bmc-oob:~# sensor-util server --threshold | grep MB_HSC_OUTPUT_CURR_A
MB_HSC_OUTPUT_CURR_A (0x30) : 4.760 Amps | (ok) | UCR: 19.720 | UNC: 18.700 | UNR: 21.420 | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep MB_HSC_INPUT_PWR_W
MB_HSC_INPUT_PWR_W (0x39) : 56.420 Watts | (ok) | UCR: 240.870 | UNC: 230.020 | UNR: 262.570 | LCR: NA | LNC: NA | LNR: NA

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 6, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 6, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D90168417. (Because this pull request was imported automatically, there will not be any future comments.)

@pabloyangWW pabloyangWW changed the title meta-facebook: gc2-es: Modify sensor threshold and HSC's r_sense to c… fbgc: fbgc2: Modify sensor threshold and HSC's r_sense to c… Jan 7, 2026
@pabloyangWW pabloyangWW changed the title fbgc: fbgc2: Modify sensor threshold and HSC's r_sense to c… gc2: es: Modify sensor threshold and HSC's r_sense to c… Jan 7, 2026
@pabloyangWW pabloyangWW changed the title gc2: es: Modify sensor threshold and HSC's r_sense to c… gc2: es: Modify sensor threshold and HSC's r_sense to correct HSC current/power scaling Jan 14, 2026
…orrect HSC current/power scaling

[Task Description]
Modify BIC (Server Board) temperature sensor thresholds and adjust HSC r_sense scaling to correct HSC current/power calculation.

[Motivation]
- Update and unify BIC temperature thresholds to match thermal policy and the management spreadsheet.
- Ensure HSC current/power measurements are correctly scaled by adjusting HSC r_sense to match actual hardware shunt/calibration.
- Provide verified sensor logs for BIC thermal and HSC power sensors.

[Design]
Update BIC (Server Board) sensor thresholds:
- MB_PCH_TEMP_C (0x04)
  - UCR = 71°C

- MB_SOC_CPU_TEMP_C (0x05)
  - UCR = 75°C
  - UNR = 78°C

- MB_DIMMA2_TEMP_C (0x06), MB_DIMMA3_TEMP_C (0x07),
  MB_DIMMA6_TEMP_C (0x0A), MB_DIMMA7_TEMP_C (0x0B)
  - UCR = 85°C

- MB_E1S_TEMP_C (0x0D)
  - UCR = 70°C

HSC related scaling:
- Adjust HSC r_sense from 0.25 -> 1
  - Purpose: correct current/power scaling used by the driver so HSC current/power sensors report accurate values that match hardware calibration/shunt configuration.

[Test Result]
Verified on GC2-ES platform using sensor-util. BIC related sensor outputs:

root@bmc-oob:~# sensor-util server --threshold | grep MB_PCH_TEMP_C
MB_PCH_TEMP_C                (0x4) :  35.000 C     | (ok) | UCR: 71.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep MB_SOC_CPU_TEMP_C
MB_SOC_CPU_TEMP_C            (0x5) :  33.000 C     | (ok) | UCR: 75.000 | UNC: NA | UNR: 78.000 | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep DIMM | grep TEMP
MB_DIMMA2_TEMP_C             (0x6) :  32.000 C     | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
MB_DIMMA3_TEMP_C             (0x7) :  31.000 C     | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
MB_DIMMA6_TEMP_C             (0xA) :  32.000 C     | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
MB_DIMMA7_TEMP_C             (0xB) :  32.000 C     | (ok) | UCR: 85.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep MB_E1S_TEMP_C
MB_E1S_TEMP_C                (0xD) :  32.000 C     | (ok) | UCR: 70.000 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

HSC power/current sensors (added as verification):
root@bmc-oob:~# sensor-util server --threshold | grep MB_HSC_OUTPUT_CURR_A
MB_HSC_OUTPUT_CURR_A         (0x30) :   4.760 Amps  | (ok) | UCR: 19.720 | UNC: 18.700 | UNR: 21.420 | LCR: NA | LNC: NA | LNR: NA

root@bmc-oob:~# sensor-util server --threshold | grep MB_HSC_INPUT_PWR_W
MB_HSC_INPUT_PWR_W           (0x39) :  56.420 Watts | (ok) | UCR: 240.870 | UNC: 230.020 | UNR: 262.570 | LCR: NA | LNC: NA | LNR: NA
@pabloyangWW pabloyangWW force-pushed the Jim/fbgc2-es/modify_sensor_threshold_and_HSC_rsense branch from e5878d9 to aa0a18b Compare January 15, 2026 03:16
@facebook-github-bot
Copy link
Contributor

@pabloyangWW has updated the pull request. You must reimport the pull request before landing.

@meta-codesync
Copy link

meta-codesync bot commented Jan 15, 2026

This pull request has been merged in 89af88c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants