Merged
Conversation
Signed-off-by: Christoph Plett <plett@faccts.de>
stgeo
approved these changes
Feb 11, 2026
Contributor
stgeo
left a comment
stgeo
left a comment
There was a problem hiding this comment.
LGTM.
Mentioning these here:
Patched in fairchem: facebookresearch/fairchem#1763 (merged, not released yet)
Underlying tnt problem fixed with meta-pytorch/tnt#1051 (merged, not released yet)
When a new version of fairchem-core is released, we can probably remove this restriction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
setuptoolsversion 82.0.0 and newer, the currentfairchempackage, and therefore UMA, no longer works due to the deprecation ofpkg_resources. This fix ensures that asetuptoolsversion lower than 82.0.0 is installed whenfairchemcoreis installed.Closes #30.