Conversation
Signed-off-by: Christoph Plett <plett@faccts.de>
stgeo
left a comment
stgeo
left a comment
There was a problem hiding this comment.
What if the download hangs - not sure there is a timeout somewhere inside get_predict_unit. I would just rather the timeout here to some reasonable download time - 60s? 120s? - but have to draw the line somewhere.
Signed-off-by: Christoph Plett <plett@faccts.de>
cplett
force-pushed
the
bugfix.uma_test
branch
from
73d4b31 to
5d929fd
Compare
stgeo
left a comment
stgeo
left a comment
There was a problem hiding this comment.
Wow, that was more infrastructure than I expected - thanks for taking the time!
I have a few minor corrections in the test_utilities and some general points about the way the setup steps are done. You don't necessarily need to change all these now, but please respond with your thoughts and perhaps open issues for later.
Signed-off-by: Christoph Plett <plett@faccts.de>
stgeo
left a comment
stgeo
left a comment
There was a problem hiding this comment.
Thanks! Some small final things and you can go ahead and merge.
| uma_model = "uma-s-1p1" | ||
|
|
||
|
|
||
| def cache_model_files( |
There was a problem hiding this comment.
IMO, this could go to oet.calculator.uma to avoid the code duplication. But we probably need another round of streamlining of the test infrastructure anyway, so no big deal for now.
There was a problem hiding this comment.
I agree that the test infrastructure requires streamlining at some point so I leave it for now. Thanks!
Signed-off-by: Christoph Plett <plett@faccts.de>
2 participants
When the UMA model files are not downloaded beforehand, the UMA test will often fail due to the 10-second timeout. This PR ensures that the model files are automatically downloaded during server setup if they are missing. This prevents the timeout and allows the UMA test to run reliably.