Conversation
Signed-off-by: Christoph Plett <plett@faccts.de>
Signed-off-by: Christoph Plett <plett@faccts.de>
stgeo
approved these changes
Dec 10, 2025
Contributor
stgeo
left a comment
stgeo
left a comment
There was a problem hiding this comment.
LGTM. I was going to question the merit of running nox on different OSs and python versions, but I guess it was already useful. 😅
| signal.signal(signal.SIGTERM, signal.SIG_DFL) | ||
| signal.signal(signal.SIGINT, signal.SIG_DFL) | ||
| signal.signal(signal.SIGHUP, signal.SIG_DFL) | ||
| if sys.platform != "win32": |
Contributor
There was a problem hiding this comment.
Could probably remove this completely - might have been over-ambitious to catch HUP.
Contributor
Author
There was a problem hiding this comment.
I don’t expect this to cause any issues anymore, so we might leave it as is for now. It may help catch occasional SSH connection losses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a workflow file for checking PRs automatically with Nox.