You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
thank you very much for the contribution. Integrating the MACE models is a great idea!
We’re currently preparing a restructuring of orca-external-tools, which is planned for very soon (likely next week). Once that’s done, I’ll come back to this PR.
Hi,
Thank you very much for your patience! The restructuring is now complete, so it would be great to include MACE at this point.
Would you be willing to align your implementation with the current code structure? Hopefully this won’t require too much additional work, and I’d be very happy to help if you run into any issues. If you don’t have the time, I can also take a look at aligning it, since edits by maintainers are allowed.
I’m really looking forward to using MACE with ORCA!
Hey @ilyes319,
Have you had a chance to adapt the MACE implementation to the new orca-external-tools structure? If not, just let me know if you need any assistance or if you'd prefer that I take over.
Hey @cplett I will not be able to do it in the next few months, so would be good if you can do it. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ORCA team,
This PR allows interface the orca-external-tools to mace. It follows the same principle as the UMA interface.