Skip to content

Conversation

@glo71317
Copy link

@glo71317 glo71317 commented Nov 7, 2024

No description provided.

@glo71317
Copy link
Author

glo71317 commented Nov 7, 2024

@ezimuel Can you please take a look this PR? As in latest composer version - https://packagist.org/packages/composer/composer#2.8.2 they have removed the support of react/promise: ^2.x hence it will allow and also not forcing to anyone to use react/promise: ^3.x just for backward compatibility.

please help us to prioritize this.

@stof
Copy link

stof commented Nov 8, 2024

The public API of ringphp actually extends from reactphp/promise interfaces, so supporting both versions is not a good idea: it means the public API of ringphp would depend on the installed version of the dependency, which would be a semver nightmare). The only reasonable way would be to make a new major version of ringphp that uses reactphp/promise 3.x exclusively.

However, note that ezimuel created this package (as a fork of the unmaintained guzzle/ringphp package) for usage in the elasticsearch-php SDK. And this SDK migrated away from using ringphp, so I doubt he is still maintaining this package.

@ezimuel
Copy link
Owner

ezimuel commented Nov 8, 2024

@glo71317 I suggest to use the latest version of composer that still support react/promise: ^2.x that is 2.7.7. You can install a specific version of composer with the --version parameter, see here. For instance:

php composer-setup.php --version=2.7.7

This command should be executed instead of the php composer-setup.php step reported in the official composer doc page here.

As @stof said, I created the fork of ringphp only to support elasticsearch-php 7.x. I'm only supporting for security fix, until next elasticsearch-php 9 will be released. This PR is more a feature request and it's not enough to upgrade to react/promise: ^3, it will require more work.

@ezimuel ezimuel closed this Nov 8, 2024
@ezimuel
Copy link
Owner

ezimuel commented Nov 8, 2024

I'm sorry @glo71317 but I need to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants