Open
Conversation
- Add unit tests for Admin views (OrgView, SystemView, AccountView, ActionsView) - Add LiveContext pattern documentation to test/CLAUDE.md for embedded view testing - Remove deprecated import_rewards_page and related files (fixes dialyzer error) - Add excoveralls dependency for code coverage analysis - Update org_view_builder tests to match current API signatures - Fix _public_test.exs to use renamed has_governable_entities? function Test coverage improvements: - system_view.ex: 72.4% → 93.1% - account_view.ex: 85.1% → 92.5% - org_view.ex: improved with new event handler tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Refactor config_page.ex mount to use positive condition check instead of `if not Admin.Public.admin?(user)`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolves Credo D-level duplicate code warnings by creating a shared helper module for building confirmation row UI elements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Revert selector's send_parent_event to use direct Phoenix send instead of LiveNest publish_event, fixing SignupPage privacy policy checkbox - Update Account.SwitchTest to use Core.DataCase and Factories.insert! since the switch now calls Org.Public.sync_next_actions_for_new_user which requires database access Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolve conflict in actions_view.ex by keeping epic/org's view model architecture while adding Feldspar data_donation_cleanup functionality. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mellelieuwes
force-pushed
the
epic/org
branch
from
cbd1962 to
5f05509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openstaand design punten (hier ga ik losse issues van maken):