Several code style and language features usage changes:

.clang-format

@@ -27,7 +27,7 @@ IndentPPDirectives: None
 IndentWidth: 4
 KeepEmptyLinesAtTheStartOfBlocks: true
 MaxEmptyLinesToKeep: 2
-NamespaceIndentation: All
+NamespaceIndentation: None
 ObjCSpaceAfterProperty: false
 ObjCSpaceBeforeProtocolList: true
 PointerAlignment: Right
@@ -43,7 +43,7 @@ SpaceBeforeInheritanceColon: true
 SpaceBeforeParens: ControlStatements
 SpaceBeforeRangeBasedForLoopColon: true
 SpaceInEmptyParentheses: false
-SpacesBeforeTrailingComments: 0
+SpacesBeforeTrailingComments: 1
 SpacesInAngles: false
 SpacesInCStyleCastParentheses: false
 SpacesInContainerLiterals: false

include/xlite/oal/Buffer.hpp

@@ -5,39 +5,39 @@
 #include <cstddef>
 #include <cstdint>
 
-namespace Lite {
+namespace lite {
 
-    namespace Sound {
+namespace sound {
 
-        enum BufferFormat : int {
-            /** Signed 16-bit mono buffer format. */
-            MONO_SIGNED_16_BIT = 0x1101,
-            /** Unsigned 8-bit mono buffer format. */
-            MONO_UNSIGNED_8_BIT = 0x1100,
-            /** Signed 16-bit stereo buffer format. */
-            STEREO_SIGNED_16_BIT = 0x1103,
-            /** Unsigned 8-bit stereo buffer format. */
-            STEREO_UNSIGNED_8_BIT = 0x1102,
-        };
+enum BufferFormat : int {
+    /** Signed 16-bit mono buffer format. */
+    MONO_SIGNED_16_BIT = 0x1101,
+    /** Unsigned 8-bit mono buffer format. */
+    MONO_UNSIGNED_8_BIT = 0x1100,
+    /** Signed 16-bit stereo buffer format. */
+    STEREO_SIGNED_16_BIT = 0x1103,
+    /** Unsigned 8-bit stereo buffer format. */
+    STEREO_UNSIGNED_8_BIT = 0x1102,
+};
 
-        class LITE_API Buffer {
-        public:
-            Buffer(BufferFormat format, int sampleRate);
-            ~Buffer();
+class LITE_API Buffer {
+public:
+    Buffer(BufferFormat format, int sampleRate);
+    ~Buffer();
 
-            void Data(const void *data, size_t size) const;
+    void Data(const void *data, std::size_t size) const;
 
-            inline uint32_t GetBuffer() const {
-                return buffer;
-            }
+    inline uint32_t GetBuffer() const {
+        return buffer;
+    }
 
-        private:
-            uint32_t buffer = 0;
+private:
+    uint32_t buffer = 0;
 
-            BufferFormat format;
-            int sampleRate;
-        };
+    BufferFormat format;
+    int sampleRate;
+};
 
-    }// namespace Sound
+} // namespace sound
 
-}// namespace Lite
+} // namespace lite

include/xlite/oal/Device.hpp

@@ -2,26 +2,26 @@
 
 #include <xlite/Config.hpp>
 
-#define LITE_MAX_MONO_SOURCES 64
-#define LITE_MAX_STEREO_SOURCES 64
+constexpr std::size_t LITE_MAX_MONO_SOURCES = 64;
+constexpr std::size_t LITE_MAX_STEREO_SOURCES = 64;
 
-namespace Lite {
+namespace lite {
 
-    namespace Sound {
+namespace sound {
 
-        class LITE_API Device {
-        public:
-            explicit Device(const char *deviceName);
+class LITE_API Device {
+public:
+    explicit Device(const char *deviceName);
 
-            Device() : Device("OpenAL Soft") {}
+    Device() : Device("OpenAL Soft") {}
 
-            ~Device();
+    ~Device();
 
-        private:
-            void *device;
-            void *context;
-        };
+private:
+    void *device;
+    void *context;
+};
 
-    }// namespace Sound
+} // namespace sound
 
-}// namespace Lite
+} // namespace lite

include/xlite/oal/Source.hpp

@@ -5,31 +5,31 @@
 
 #include <cstdint>
 
-namespace Lite {
+namespace lite {
 
-    namespace Sound {
+namespace sound {
 
-        class LITE_API Source {
-        public:
-            Source();
-            ~Source();
+class LITE_API Source {
+public:
+    Source();
+    ~Source();
 
-            void Play() const;
-            void Stop() const;
-            void Loop(bool loop) const;
-            void Gain(float gain) const;
-            bool IsPlaying() const;
-            void Attach(const Buffer &buffer) const;
-            void Detach() const;
-            bool Available() const;
+    void Play() const;
+    void Stop() const;
+    void Loop(bool loop) const;
+    void Gain(float gain) const;
+    bool IsPlaying() const;
+    void Attach(const Buffer &buffer) const;
+    void Detach() const;
+    bool Available() const;
 
-        private:
-            uint32_t source = 0;
+private:
+    uint32_t source = 0;
 
-            Source(Source &) = delete;
-            Source(Source const &) = delete;
-        };
+    Source(Source &) = delete;
+    Source(Source const &) = delete;
+};
 
-    }// namespace Sound
+} // namespace sound
 
-}// namespace Lite
+} // namespace lite

include/xlite/sound/Audio.hpp

@@ -3,21 +3,21 @@
 #include <xlite/Config.hpp>
 #include <xlite/oal/Source.hpp>
 
-namespace Lite {
+namespace lite {
 
-    namespace Sound {
+namespace sound {
 
-        class LITE_API Audio {
-        public:
-            Audio(BufferFormat channelFormat, int sampleRate, const void *data, size_t size);
-            ~Audio() = default;
+class LITE_API Audio {
+public:
+    Audio(BufferFormat channelFormat, int sampleRate, const void *data, std::size_t size);
+    ~Audio() = default;
 
-            void Play(const Source &source) const;
+    void Play(const Source &source) const;
 
-        private:
-            Buffer buffer;
-        };
+private:
+    Buffer buffer;
+};
 
-    }// namespace Sound
+} // namespace sound
 
-}// namespace Lite
+} // namespace lite

include/xlite/sound/Engine.hpp

@@ -8,22 +8,22 @@
 #include <memory>
 #include <string>
 
-namespace Lite {
+namespace lite {
 
-    namespace Sound {
+namespace sound {
 
-        class LITE_API Engine {
-        public:
-            Engine() = default;
-            ~Engine() = default;
+class LITE_API Engine {
+public:
+    Engine() = default;
+    ~Engine() = default;
 
-            bool Play(const Audio &audio);
+    bool Play(const Audio &audio);
 
-        private:
-            Device device;
-            Pool pool;
-        };
+private:
+    Device device;
+    Pool pool;
+};
 
-    }// namespace Sound
+} // namespace sound
 
-}// namespace Lite
+} // namespace lite

include/xlite/sound/Pool.hpp

@@ -10,30 +10,30 @@
 
 #pragma warning(push)
 #pragma warning(disable : 4251)// Template warnings on vector/queue private members
-namespace Lite {
+namespace lite {
 
-    namespace Sound {
+namespace sound {
 
-        class LITE_API Pool {
-        public:
-            Pool();
-            ~Pool() = default;
+class LITE_API Pool {
+public:
+    Pool();
+    ~Pool() = default;
 
-            std::shared_ptr<Source> Fetch();
+    std::shared_ptr<Source> Fetch();
 
-            inline size_t Size() const {
-                return sources.size();
-            }
+    std::size_t Size() const {
+        return sources.size();
+    }
 
-        private:
-            std::vector<std::shared_ptr<Source>> sources;
-            std::vector<std::shared_ptr<Source>> acquired;
-            std::queue<std::shared_ptr<Source>> available;
+private:
+    std::vector<std::shared_ptr<Source>> sources;
+    std::vector<std::shared_ptr<Source>> acquired;
+    std::queue<std::shared_ptr<Source>> available;
 
-            void Update();
-        };
+    void Update();
+};
 
-    }// namespace Sound
+} // namespace sound
 
-}// namespace Lite
+} // namespace lite
 #pragma warning(pop)

src/oal/Buffer.cpp

@@ -2,7 +2,9 @@
 
 #include <AL/al.h>
 
-using namespace Lite::Sound;
+namespace lite {
+
+namespace sound {
 
 Buffer::Buffer(BufferFormat format, int sampleRate)
     : format(format), sampleRate(sampleRate) {
@@ -13,6 +15,10 @@ Buffer::~Buffer() {
     alDeleteBuffers(1, &buffer);
 }
 
-void Buffer::Data(const void *data, size_t size) const {
+void Buffer::Data(const void *data, std::size_t size) const {
     alBufferData(buffer, format, data, static_cast<ALint>(size), sampleRate);
 }
+
+} // namespace sound
+
+} // namespace lite

src/oal/Device.cpp

@@ -2,7 +2,9 @@
 
 #include <AL/alc.h>
 
-using namespace Lite::Sound;
+namespace lite {
+
+namespace sound {
 
 Device::Device(const char *deviceName) {
     device = alcOpenDevice(deviceName);
@@ -20,3 +22,7 @@ Device::~Device() {
     alcDestroyContext(static_cast<ALCcontext *>(context));
     alcCloseDevice(static_cast<ALCdevice *>(device));
 }
+
+} // namespace sound
+
+} // namespace lite

src/oal/Source.cpp

@@ -2,7 +2,9 @@
 
 #include <AL/al.h>
 
-using namespace Lite::Sound;
+namespace lite {
+
+namespace sound {
 
 Source::Source() {
     alGenSources(1, &source);
@@ -56,3 +58,7 @@ bool Source::Available() const {
 
     return AL_STOPPED == state;
 }
+
+} // namespace sound
+
+} // namespace lite

src/sound/Audio.cpp

@@ -1,8 +1,10 @@
 #include <xlite/sound/Audio.hpp>
 
-using namespace Lite::Sound;
+namespace lite {
 
-Audio::Audio(BufferFormat channelFormat, int sampleRate, const void *data, size_t size)
+namespace sound {
+
+Audio::Audio(BufferFormat channelFormat, int sampleRate, const void *data, std::size_t size)
     : buffer(channelFormat, sampleRate) {
     buffer.Data(data, size);
 }
@@ -11,3 +13,7 @@ void Audio::Play(const Source &source) const {
     source.Attach(buffer);
     source.Play();
 }
+
+} // namespace sound
+
+} // namespace lite

src/sound/Engine.cpp

@@ -1,10 +1,16 @@
 #include <xlite/sound/Engine.hpp>
 
-using namespace Lite::Sound;
+namespace lite {
+
+namespace sound {
 
 bool Engine::Play(const Audio &audio) {
     auto source = pool.Fetch();
     audio.Play(*source);
 
     return true;
 }
+
+} // namespace sound
+
+} // namespace lite