Fix file size validation issue in multer# 1348#1361
Open
divya2212001 wants to merge 1 commit intoexpressjs:mainfrom
Open
Fix file size validation issue in multer# 1348#1361divya2212001 wants to merge 1 commit intoexpressjs:mainfrom
divya2212001 wants to merge 1 commit intoexpressjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an off-by-one issue where Multer throws a "File too large" error
when the uploaded file size is exactly equal to
limits.fileSize.Root Cause
Busboy emits a
limitevent when the file size equals the limit.Multer interpreted this as an overflow, rejecting valid uploads.
Fix
Adjusted the limit logic by incrementing
limits.fileSizeby 1 beforepassing to Busboy. This ensures only files exceeding the limit are rejected.
Testing
✅ Uploaded files with size exactly equal to
limits.fileSize→ success✅ Uploaded files exceeding the limit → correctly rejected