Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
| "dependencies": { | ||
| "append-field": "^1.0.0", | ||
| "busboy": "^1.0.0", | ||
| "@fastify/busboy": "^1.0.0", |
Member
There was a problem hiding this comment.
- Error Handling
should gracefully handle more than one error at a time:
Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
- actual - expected
- 'LIMIT_FILE_COUNT' - 'LIMIT_FILE_SIZE'
Test are failed because of changes in busboy
Member
Author
There was a problem hiding this comment.
No, actually that change shouldn't be here. I was testing some things and accidentally committed it here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1035