[FEAT] Google Cloud Functions Support#1307
Open
emregunel wants to merge 4 commits intoexpressjs:mainfrom
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Thanks @emregunel for this PR! I was checking the CI reports and seems like there are some linting issues, can you run |
Author
|
Thanks @UlisesGascon for looking at it :) I fixed linting with latest commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add streamHandler option for Google Cloud Functions support
Problem
Multer currently uses
req.pipe(busboy)to process multipart form data. This works well in most environments, but causes issues in Google Cloud Functions (GCF) where the request body is pre-processed and made available asreq.rawBody. When Multer tries to pipe the request in GCF, it fails because the request stream has already been consumed.Solution
This PR adds a new
streamHandleroption that allows customizing how request data is fed to busboy. Instead of hardcodingreq.pipe(busboy), the middleware now accepts a custom function that can handle both standard Express environments and pre-processed environments like GCF.Implementation Details
streamHandlerconfiguration option to the Multer constructorreq.pipe(busboy)behaviorExample Usage
For Google Cloud Functions or similar environments where the request body is pre-processed:
Benefits
Testing
Added new tests that verify:
All existing tests continue to pass.
Documentation
Added the new
streamHandleroption to the README.md with example usage for Google Cloud Functions environments.Related Issues
This PR resolves the issue described in #1189 where Multer breaks in Google Cloud Functions due to pre-processed request bodies.