Conversation
17 tasks
Member
this is not really the case. see non-goals in the ADR therefore, we should not drop support for older versions if we don't have a reason beyond "it's old node" |
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
We can check if there is a need for engines change once all the dependencies are updated
Member
Author
|
@ctcpip We need to update type-is, which supports Node >= 18 :) |
Member
Author
ctcpip
reviewed
Jun 2, 2025
ctcpip
approved these changes
Jun 2, 2025
UlisesGascon
approved these changes
Jun 3, 2025
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Please don't forget to update the CHANGELOG.md file as this is a breaking change :)
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Member
Author
|
@UlisesGascon I’ve already updated the changelog |
UlisesGascon
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with other packages, we support Node >=18 🙂 for this new version