Skip to content

Comments

Retry Node install without NVM mirror after diagnostics#3425

Open
sjchmiela wants to merge 1 commit intomainfrom
stanley/retry-node-install-without-nvm
Open

Retry Node install without NVM mirror after diagnostics#3425
sjchmiela wants to merge 1 commit intomainfrom
stanley/retry-node-install-without-nvm

Conversation

@sjchmiela
Copy link
Contributor

Summary

  • log nvm ls-remote output whenever a custom Node.js install fails so diagnostics are always available
  • refactor the worker installNode flow to share an install helper, rerun without NVM_NODEJS_ORG_MIRROR when present, and keep downstream behavior unchanged
  • add unit tests that cover diagnostics logging, the mirror-free retry, and eventual failure when both attempts fail

Testing

  • Not run (not requested)

@github-actions
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant