Skip to content

Comments

Revert "Use auth code flow (#3398)"#3422

Merged
byronkarlen merged 1 commit intomainfrom
wbk/fix-eas-login-sso
Feb 23, 2026
Merged

Revert "Use auth code flow (#3398)"#3422
byronkarlen merged 1 commit intomainfrom
wbk/fix-eas-login-sso

Conversation

@byronkarlen
Copy link
Contributor

@byronkarlen byronkarlen commented Feb 23, 2026

Why

This reverts commit 1604b7b. (PR #3398)

eas login --sso is broken.

How

How did you build this feature or fix this bug and why?

Test Plan

Ran eas login -sso successfully against staging. Used the uuid suffix with stub-idp to avoid signup flow.

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@byronkarlen byronkarlen force-pushed the wbk/fix-eas-login-sso branch from 81c12b8 to f423078 Compare February 23, 2026 20:22
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@byronkarlen byronkarlen merged commit 0fdf2dd into main Feb 23, 2026
7 checks passed
@byronkarlen byronkarlen deleted the wbk/fix-eas-login-sso branch February 23, 2026 20:30
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.58%. Comparing base (0dcd6d4) to head (f423078).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...es/eas-cli/src/user/expoBrowserAuthFlowLauncher.ts 25.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   52.54%   52.58%   +0.04%     
==========================================
  Files         806      806              
  Lines       33621    33592      -29     
  Branches     6986     6983       -3     
==========================================
- Hits        17664    17662       -2     
+ Misses      14571    14546      -25     
+ Partials     1386     1384       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants