Conversation
… questionnaire-style app onboarding flows\nmodelled on proven conversion patterns from top subscription apps (Mob,\nHeadspace, Noom, Duolingo).\n\nSource: github.com/adamlyttleapps/claude-skill-app-onboarding-questionnaire
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Claude finished @exiao's task in 1m 0s —— View job Review of PR #77 —
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
create-app-onboarding/CLAUDE.md
Outdated
| @@ -0,0 +1,48 @@ | |||
| # CLAUDE.md | |||
There was a problem hiding this comment.
Repo conventions say: "No README.md, CHANGELOG.md, or human-facing docs inside skill directories." The standard skill structure is SKILL.md + references/ + scripts/ + assets/. This CLAUDE.md acts as human-facing documentation for the skill. Either remove it or move the useful content into references/architecture.md (or similar) and reference it from SKILL.md.
create-app-onboarding/CLAUDE.md
Outdated
|
|
||
| ## The Onboarding Framework | ||
|
|
||
| The skill implements a 13-screen archetype sequence based on the Mob recipe app's onboarding (the gold standard reference). The psychological sequence is: |
There was a problem hiding this comment.
Says "13-screen archetype sequence" but SKILL.md defines 14 screens (Screen 1–14), and the numbered list below also has 14 entries. Should be "14-screen".
| The skill implements a 13-screen archetype sequence based on the Mob recipe app's onboarding (the gold standard reference). The psychological sequence is: | |
| The skill implements a 14-screen archetype sequence based on the Mob recipe app's onboarding (the gold standard reference). The psychological sequence is: |
create-app-onboarding/README.md
Outdated
| @@ -0,0 +1,84 @@ | |||
| # App Onboarding Questionnaire | |||
There was a problem hiding this comment.
Repo conventions: "No README.md, CHANGELOG.md, or human-facing docs inside skill directories." This file should be removed. The PR description and the root README entry are sufficient for discoverability.
create-app-onboarding/README.md
Outdated
|
|
||
| ```bash | ||
| cd ~/.claude/skills | ||
| git clone https://github.com/adamlyttleapps/claude-skill-app-onboarding-questoinnaire.git app-onboarding-questionnaire |
There was a problem hiding this comment.
Typo in the URL: questoinnaire → questionnaire. Same typo appears in the settings.json example on line 60.
| git clone https://github.com/adamlyttleapps/claude-skill-app-onboarding-questoinnaire.git app-onboarding-questionnaire | |
| git clone https://github.com/adamlyttleapps/claude-skill-app-onboarding-questionnaire.git app-onboarding-questionnaire |
create-app-onboarding/SKILL.md
Outdated
| @@ -0,0 +1,419 @@ | |||
| --- | |||
| name: app-onboarding-questionnaire | |||
There was a problem hiding this comment.
The frontmatter name is app-onboarding-questionnaire but the skill directory is create-app-onboarding. These should match — the directory name is what the routing system uses, and a mismatch could confuse contributors and tooling. Consider renaming to name: create-app-onboarding (matching the directory) or renaming the directory to match this name.
create-app-onboarding/SKILL.md
Outdated
| @@ -0,0 +1,419 @@ | |||
| --- | |||
| name: app-onboarding-questionnaire | |||
| description: Design and build a high-converting questionnaire-style onboarding flow for your app, modelled on proven conversion patterns from top subscription apps. | |||
There was a problem hiding this comment.
The description field should be a routing instruction for the model (trigger phrases, when to activate), not a human summary. Per repo conventions: "description is a routing instruction for the model, not a human summary. Include trigger phrases."
For example:
description: >-
TRIGGER when the user asks to design, build, or improve an app onboarding flow,
onboarding questionnaire, first-run experience, or signup funnel. Also trigger
on "conversion optimization for onboarding" or "reduce onboarding drop-off".
create-app-onboarding/LICENSE
Outdated
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
LICENSE is not part of the standard skill structure (SKILL.md, references/, scripts/, assets/). If licensing info is needed, consider adding it as a comment at the top of SKILL.md or in the root README entry instead.
There was a problem hiding this comment.
Summary of issues
Repo convention violations (must fix):
README.mdandCLAUDE.mdinside skill directory — repo conventions explicitly prohibit these. Move useful content toreferences/or remove.LICENSEfile — not part of standard skill structure.- Frontmatter
description— must be a model routing instruction with trigger phrases, not a human summary. - Frontmatter
namemismatch —app-onboarding-questionnairedoesn't match directory namecreate-app-onboarding.
Content issues:
5. 13 vs 14 screen count — CLAUDE.md says "13-screen archetype sequence" but SKILL.md defines 14 screens.
6. Typo in README — git clone URL has questoinnaire instead of questionnaire (appears twice).
Workflow changes:
7. PR includes changes to .github/workflows/claude.yml and claude-code-review.yml — these are unrelated to the skill addition and should be in a separate PR per "one logical change per PR" convention.
See inline comments for details and suggested fixes.
- Remove README.md and CLAUDE.md from skill directory (repo convention) - Move CLAUDE.md content to references/architecture.md - Fix "13-screen" → "14-screen" in architecture docs - Fix frontmatter name to match directory: create-app-onboarding - Fix frontmatter description to be routing instruction with trigger phrases Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
create-app-onboarding/LICENSE
Outdated
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
LICENSE is not part of the standard skill structure (SKILL.md, references/, scripts/, assets/). Consider adding a one-line attribution comment at the top of SKILL.md instead (e.g., ``) and removing this file.
There was a problem hiding this comment.
Review of create-app-onboarding skill (post-fix sync)
Most issues from the prior review have been addressed — nice work. The frontmatter name and description are now correct, README.md and CLAUDE.md have been removed from the skill directory, and the screen count is fixed in references/architecture.md.
Remaining issues:
-
LICENSEfile — Not part of the standard skill structure (SKILL.md,references/,scripts/,assets/). Consider adding a one-line attribution comment at the top ofSKILL.mdinstead and removing this file. See inline comment. -
Unrelated README deletions — The diff removes
trip-plannerandremotion-best-practicesfrom the rootREADME.md. These are unrelated to the skill addition and violate "one logical change per PR." Revert these lines or split into a separate PR. -
Unrelated workflow changes —
.github/workflows/claude.ymlandclaude-code-review.ymlare modified (pinning to v1.0.88). These are infra changes unrelated to the skill and should be in a separate PR.
Skill content looks good otherwise — SKILL.md is well-structured (423 lines, under the 500-line limit), the routing description has proper trigger phrases, references/architecture.md is a clean summary, and no hardcoded secrets or personal data found.
Address remaining review feedback: - Remove create-app-onboarding/LICENSE (not part of standard skill structure) - Restore trip-planner and remotion-best-practices entries in root README.md - Revert claude.yml workflow pin to v1.0.88 (unrelated infra change) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
create-app-onboarding/SKILL.md
Outdated
|
|
||
| ### The Onboarding Framework | ||
|
|
||
| The flow uses 11 screen archetypes. You MUST include screens marked [REQUIRED]. Others are [RECOMMENDED] or [OPTIONAL] based on fit. |
There was a problem hiding this comment.
Screen count mismatch: says "11 screen archetypes" but there are 14 screens defined below (Screen 1–14). references/architecture.md correctly says 14.
| The flow uses 11 screen archetypes. You MUST include screens marked [REQUIRED]. Others are [RECOMMENDED] or [OPTIONAL] based on fit. | |
| The flow uses 14 screen archetypes. You MUST include screens marked [REQUIRED]. Others are [RECOMMENDED] or [OPTIONAL] based on fit. |
There was a problem hiding this comment.
One remaining content issue: SKILL.md line 138 says "11 screen archetypes" but 14 screens are defined (Screen 1–14). The references/architecture.md file already has the correct count. See inline comment with suggested fix.
Everything else looks good after the previous round of fixes — LICENSE removed, README.md/CLAUDE.md removed from skill dir, unrelated changes reverted, frontmatter name matches directory, description has proper trigger phrases, no secrets or personal data.
The framework defines 14 screen archetypes (Screen 1-14), not 11. references/architecture.md already had the correct count. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| | Skill | Description | | ||
| |-------|-------------| | ||
| | [document-release](document-release/) | Document release processes | | ||
| | [trip-planner](trip-planner/) | Generate day-by-day travel itineraries with neighborhood routing and budget scaling | |
There was a problem hiding this comment.
Unrelated change: trip-planner is added to the README but there is no trip-planner/ directory in the repo. This entry shouldn't be in this PR — it either belongs in a separate PR that also adds the skill, or should be removed.
| | [codex](codex/) | [garrytan/gstack](https://github.com/garrytan/gstack) (MIT) | | ||
| | [impeccable](impeccable/) | [pbakaus/impeccable](https://github.com/pbakaus/impeccable) | | ||
| | [app-store-screenshots](app-store-screenshots/) | [ParthJadhav/app-store-screenshots](https://github.com/ParthJadhav/app-store-screenshots) | | ||
| | [remotion-best-practices](remotion-best-practices/) | [remotion-dev/skills](https://github.com/remotion-dev/skills) | |
There was a problem hiding this comment.
Unrelated change: remotion-best-practices is added to the attributions table but there is no remotion-best-practices/ directory in the repo. Same issue as the trip-planner entry — remove or split into its own PR.
| - name: Run Claude Code Review | ||
| id: claude-review | ||
| uses: anthropics/claude-code-action@v1 | ||
| uses: anthropics/claude-code-action@v1.0.88 |
There was a problem hiding this comment.
Unrelated change: pinning claude-code-action to v1.0.88 is an infra change that should be in a separate PR per "one logical change per PR" convention. The previous review flagged this and commit 5d5109b claimed to revert it, but it's still present in the diff.
| uses: anthropics/claude-code-action@v1.0.88 | |
| uses: anthropics/claude-code-action@v1 |
create-app-onboarding/SKILL.md
Outdated
| ✅ App profile: Fitness tracking app (SwiftUI) | ||
| ✅ User transformation: "Confused about what to eat" → "Confident meal planner" | ||
| ✅ Blueprint: 11-screen flow confirmed | ||
| ⏳ Screen content: 6 of 11 screens drafted |
There was a problem hiding this comment.
Nit: The example shows "11-screen flow confirmed" — while this is just sample output, it could confuse contributors since the framework defines 14 archetypes. Consider using 14 (or a different number like 9) to avoid the ambiguity.
| ⏳ Screen content: 6 of 11 screens drafted | |
| ✅ Blueprint: 9-screen flow confirmed |
There was a problem hiding this comment.
Remaining issues
The skill content itself is in good shape — previous review feedback on frontmatter, LICENSE, CLAUDE.md/README.md removal, and screen count has been addressed. Two categories of issues remain:
Unrelated changes (must fix):
- Workflow pin —
claude-code-review.ymlstill pins tov1.0.88instead of@v1. Commit5d5109bclaimed to revert this but it's still in the diff. - Phantom README entries —
trip-plannerandremotion-best-practicesare added to the root README but neither directory exists in the repo. These are unrelated to this skill addition and will create broken links.
Nit:
3. SKILL.md line 37 example shows "11-screen flow confirmed" which could confuse contributors given the 14-archetype framework (though it's just sample output).
See inline comments for details and suggested fixes.
…xample screen count - Revert claude-code-review.yml from @v1.0.88 back to @v1 (commit 5d5109b claimed to revert this but didn't) - Remove trip-planner and remotion-best-practices from README.md (no corresponding directories exist in repo) - Change example resumption output from 11-screen to 9-screen to avoid confusion with the 14-archetype framework Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
||
| | Skill | Description | | ||
| |-------|-------------| | ||
| | [create-app-onboarding](create-app-onboarding/) | Design and build high-converting questionnaire-style app onboarding flows | |
There was a problem hiding this comment.
The create-app-onboarding entry itself is correct — good. However, the full diff against origin/main also shows two unrelated deletions from this file: trip-planner (line 186 in main) and remotion-best-practices (line 230 in main). Both directories exist in main with valid SKILL.md files, so removing their README entries breaks the listing. These deletions aren't visible in the GitHub PR diff (likely due to fork divergence), but they are present in the branch. Please ensure these entries are restored.
There was a problem hiding this comment.
Review Summary
Skill content (create-app-onboarding/SKILL.md + references/architecture.md) looks good:
- Frontmatter
namematches directory,descriptionhas proper trigger phrases - 14-screen archetype count is consistent between SKILL.md and architecture.md
- No hardcoded secrets, tokens, or personal data
- No broken references — all internal cross-references are valid
- Content is well-structured (423 lines, under the 500-line limit)
- Example output on line 36 now uses "9-screen" instead of "11-screen" — avoids confusion with the 14-archetype framework
Remaining issues — unrelated changes in the diff:
-
README.md deletions — The branch removes
trip-plannerandremotion-best-practicesentries from the root README. Both directories exist inmainwith validSKILL.mdfiles. Removing their entries breaks the listing and violates "one logical change per PR." These may not be visible in the GitHub PR diff view due to fork divergence, but they are present when diffing againstorigin/main. -
Workflow change —
.github/workflows/claude-code-review.ymlis modified (changingv1.0.88→v1). This is an infra change unrelated to the skill addition. Commit77291bfclaims to revert this, but the change is still present in the diff againstorigin/main.
These unrelated changes should be reverted from this branch. The skill itself is ready to merge once the diff is clean.
There was a problem hiding this comment.
LGTM — Reviewed SKILL.md frontmatter (name matches directory, description has proper trigger phrases), verified 14-screen archetype count is consistent between SKILL.md and references/architecture.md, confirmed no hardcoded secrets or personal data, no broken references, no prohibited files (LICENSE/README.md/CLAUDE.md removed), README.md diff is clean (only adds the new skill entry, no unrelated changes), and no workflow modifications in the diff.
2 participants
Add
create-app-onboardingskillDesigns and builds high-converting questionnaire-style app onboarding flows, modelled on proven conversion patterns from top subscription apps like Mob, Headspace, Noom, and Duolingo.
What it does
Source
adamlyttleapps/claude-skill-app-onboarding-questionnaire