Create mentoring.md for Beer Song in C##2359
Open
gablemathias wants to merge 2 commits intoexercism:mainfrom
Open
Create mentoring.md for Beer Song in C##2359gablemathias wants to merge 2 commits intoexercism:mainfrom
gablemathias wants to merge 2 commits intoexercism:mainfrom
Conversation
Mentoring guide for the given exercise to help others mentoring this in the future. It comes with the mentoring proposal, an exemplar solution and a link with a possible learning material.
IsaacG
reviewed
Sep 8, 2024
IsaacG
reviewed
Sep 12, 2024
| The student would normally go first using the if/else and if/else if statements. | ||
| Suggesting the use of case statements first will be optimal and instructive. | ||
|
|
||
| The student would normally go first using the if/else and if/else if statements. That's not wrong, |
Member
There was a problem hiding this comment.
Exercism markdown standard is one sentence per line.
Member
ErikSchierboom
left a comment
There was a problem hiding this comment.
Thanks for this! Could you maybe try and format this like existing mentoring notes? Such as https://github.com/exercism/website-copy/blob/main/tracks/csharp/exercises/hamming/mentoring.md
Member
ErikSchierboom
left a comment
There was a problem hiding this comment.
It might be worth listing more possible solutions, e.g. this one has logic deduplicated:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentoring guide for the given exercise to help others mentoring this in the future.
It comes with: