-
-
Notifications
You must be signed in to change notification settings - Fork 558
Perfect Numbers: add perfect-square abundant test (196) #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
|
The CI test shows the .input.number line is over indented. |
Align input.number indentation with existing cases.
fixed it |
IsaacG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give the PR at least 24 hours so people can have a chance to chime in before we merge it.
|
LGTM |
We sync new test exercism/problem-specifications#2620
Add a perfect-square test case where missing sqrt(n) changes classification (196 -> abundant).
Forum thread: https://forum.exercism.org/t/perfect-numbers-perfect-square-test-cases/23862