Skip to content

Implemented the Intergalactic Transmission exercise#183

Merged
rmonnet merged 1 commit intoexercism:mainfrom
rmonnet:ex-intergalatic-transmission
Feb 5, 2026
Merged

Implemented the Intergalactic Transmission exercise#183
rmonnet merged 1 commit intoexercism:mainfrom
rmonnet:ex-intergalatic-transmission

Conversation

@rmonnet
Copy link
Contributor

@rmonnet rmonnet commented Feb 4, 2026

No description provided.

@rmonnet rmonnet requested a review from glennj February 4, 2026 03:00
@rmonnet rmonnet added x:action/improve Improve existing functionality/content x:type/content Work on content (e.g. exercises, concepts) labels Feb 4, 2026
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to put helper functions up top so that students know they don't need to implement them.

Otherwise OK

@rmonnet
Copy link
Contributor Author

rmonnet commented Feb 5, 2026

I understand your point of view but I think it is a matter of taste. I like what Bob Martin says about arranging the functions in a file:

"To say it another way, we want the code to read like a top-down narrative. We want every function to be followed by those at the next level of abstraction so that we can read the program, descending one level of detail at a time..."

I didn't think the students had access to the example.odin file unless they look into the github repository.

@rmonnet rmonnet merged commit 1b11bf8 into exercism:main Feb 5, 2026
4 checks passed
@glennj
Copy link
Contributor

glennj commented Feb 5, 2026

I didn't think the students had access to the example.odin file unless they look into the github repository.

I commented in the wrong place: I was talking about the helper in the test file.

@rmonnet
Copy link
Contributor Author

rmonnet commented Feb 5, 2026

Ok, I'll move then to the top. Will push and merge in a separate PR since it is just moving things around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/improve Improve existing functionality/content x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants