Open
Conversation
Contributor
Author
|
Extended Unicode discussion, based on your forum post. There's now a (still too long) introduction, so I'll move this PR out of draft. |
SleeplessByte
approved these changes
Sep 2, 2025
Comment on lines
+85
to
+89
| - Test character type with: | ||
| - [`isLetter()`][ref-isletter], covers many alphabets | ||
| - [`isDigit()`][ref-isdigit], in range 0..9 | ||
| - `isLetterOrDigit()`, combines the previous two | ||
| - [`isWhitespace()`][ref-iswhitespace], any whitespace character |
Member
There was a problem hiding this comment.
Suggested change
| - Test character type with: | |
| - [`isLetter()`][ref-isletter], covers many alphabets | |
| - [`isDigit()`][ref-isdigit], in range 0..9 | |
| - `isLetterOrDigit()`, combines the previous two | |
| - [`isWhitespace()`][ref-iswhitespace], any whitespace character | |
| - Test character type with: | |
| - [`isLetter()`][ref-isletter], covers many alphabets (the Lu, Ll, Lt, Lm, and Lo categories in unicode) | |
| - [`isDigit()`][ref-isdigit], in range 0..9 (the Nd category in unicode) | |
| - `isLetterOrDigit()`, combines the previous two | |
| - [`isWhitespace()`][ref-iswhitespace], any whitespace character (the Cc, Zp, Zl, and Zs categories in unicode) |
I think this is the correct markdown format.
For about.md only, I think we can explain how it's implemented by specifying the unicode categories (that's how these functions work!)
| kt.joinToString("_") // => "k_o_t_l_i_n" | ||
| ``` | ||
|
|
||
| Note that `joinToString()` operates on a List or Array. |
Member
There was a problem hiding this comment.
Suggested change
| Note that `joinToString()` operates on a List or Array. | |
| Note that `joinToString()` operates on a List or Array. |
What was the reason for this sentence?
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a bit confused about the way Kotlin implements Unicode as fixed-width 16-bit, so I'll ask for clarification on the forum before marking this ready for review.