Implement analyzer for tim-from-marketing concept exercise#270
Merged
kahgoh merged 2 commits intoexercism:mainfrom May 7, 2025
Merged
Implement analyzer for tim-from-marketing concept exercise#270kahgoh merged 2 commits intoexercism:mainfrom
analyzer for tim-from-marketing concept exercise#270kahgoh merged 2 commits intoexercism:mainfrom
Conversation
Member
|
+cc @exercism/java |
kahgoh
reviewed
May 5, 2025
Member
kahgoh
left a comment
kahgoh
left a comment
There was a problem hiding this comment.
Thanks for this! I think this generally looks good - just some minor formatting. Have you also created a PR to add the comment for use null literal in the website-copy?
Comment on lines
25
to
28
| if (output.getComments().isEmpty()) { | ||
| output.addComment(new ExemplarSolution(EXERCISE_NAME)); | ||
|
|
||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (output.getComments().isEmpty()) { | |
| output.addComment(new ExemplarSolution(EXERCISE_NAME)); | |
| } | |
| if (output.getComments().isEmpty()) { | |
| output.addComment(new ExemplarSolution(EXERCISE_NAME)); | |
| } |
IsaacG
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
ToDo: