Open
Conversation
BNAndras
reviewed
Mar 6, 2024
Member
There was a problem hiding this comment.
More tests are present here than exist in the test suite. Unimplemented tests should be marked with include = false underneath.
Contributor
Author
There was a problem hiding this comment.
Oh. I thought that if the first one has Include = false then the re-implementation will be default as not included as well. I didn't know we have to mark them all. Gonna fix it.
Edit: On a second thought, let just wait for pfertyk, if he wants to forgone these then I will just mark them as include = false, else I will add them and return null. This PR should be merged last in the chain anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.