Merged
Conversation
(To simplify verify-exercises file in main gdscript repo)
IsaacG
reviewed
Jun 28, 2025
bin/test-local-gdscript-solution.sh
Outdated
| mkdir -p "${output_dir}" | ||
|
|
||
| (cd /opt/exercism/gdscript/test-runner && bin/run.sh "$slug" "$solution_dir" "$output_dir") || { | ||
| (cd /opt/exercism/gdscript/test-runner && godot --headless -s bin/test_runner.gd -- "${slug}" "${solution_dir}") || { |
Member
There was a problem hiding this comment.
If you're going to use {} maybe use them consistently?
Contributor
Author
There was a problem hiding this comment.
Good point! My bad, fixed. ✔
Contributor
Author
|
@IsaacG I think if we merge this and make a dummy change over at exercism/gdscript#102, both CIs should be working. (The main thing in the other repo was that I couldn't use OS.execute in GDScript to refer to (cd && run.sh) the way bash did, so I changed run.sh over here to run from wherever it lives, which changed the directories hardcoded into the output. But the tests pass now over on this end.) |
IsaacG
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://forum.exercism.org/t/create-new-track-for-gdscript/3955/209
Goes with exercism/gdscript#102