Merged
Conversation
ryanplusplus
reviewed
Mar 9, 2021
docs/CONTRIBUTING.md
Outdated
| ``` | ||
| +-- <my-exercise> | ||
| <pre> | ||
| +-- <my-exercise> |
Member
There was a problem hiding this comment.
Do you need to use < below as well? The rich diff shows that it's messed up as-is.
ryanplusplus
reviewed
Mar 9, 2021
Co-authored-by: Ryan Hartlage <ryanplusplus@gmail.com>
Fix some typos and grammar, unify URL syntax, fix some line breaks
Fix line breaks and bad URLS, unify URL syntax
Improve grammar also
Improve grammar also
Contributor
Author
|
Already had another branch with work done to lint all the docs with some changes that fixed the angle brackets issue. Next step may be to add markdown lint CI... |
ryanplusplus
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a question on Slack about the CI and specifically about the decision to stick with Ubuntu 18.04.
So I have taken the opportunity to update the docs on these points as lots has changed.
The docs will probably need changing a bit for v3 anyway, but I figure this information will be the same at least.