SED-4417 Grid layout for executions report#1325
Draft
Conversation
Summary of ChangesHello @dvladir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user interface flexibility by introducing a new, highly customizable editable grid layout module. This module allows users to dynamically resize and rearrange widgets within the application, with a particular focus on improving the execution reports. The changes provide a more interactive and personalized experience for visualizing data, as widget positions and sizes are now persistent across user sessions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Overall, this is a significant and well-structured feature addition. The use of Angular signals and modern practices is commendable. I've identified a few areas for improvement, including fixing some typos, correcting a logic bug in cell calculation (with consideration for zero-width components), and refactoring a repetitive block of code for better maintainability. Please see the detailed comments below.
projects/step-core/src/lib/modules/editable-grid-layout/directives/grid-dimensions.directive.ts
Show resolved
Hide resolved
| providedIn: 'root', | ||
| }) | ||
| export class GridSettingsRegistryService { | ||
| private girdsSettings: Map<string, GridElementInfo[]> = new Map(); |
There was a problem hiding this comment.
There's a typo in the property name girdsSettings. It should be gridSettings. This typo appears in multiple places within this file (lines 15, 18, 19, 21, 25). Please correct it for better code clarity and maintainability.
Suggested change
| private girdsSettings: Map<string, GridElementInfo[]> = new Map(); | |
| private gridSettings: Map<string, GridElementInfo[]> = new Map(); |
projects/step-core/src/lib/modules/editable-grid-layout/index.ts
Outdated
Show resolved
Hide resolved
Comment on lines
8
to
11
| // eslint-disable-next-line @angular-eslint/prefer-inject | ||
| constructor(@Inject(SESSION_STORAGE) _sessionStorage: Storage) { | ||
| super(_sessionStorage, 'GRID'); | ||
| } |
There was a problem hiding this comment.
The eslint-disable-next-line comment indicates a preference for using the inject() function over constructor injection. You can refactor the constructor to adhere to this style, which also makes the code slightly more concise.
constructor() {
super(inject(SESSION_STORAGE), 'GRID');
}
...tep-core/src/lib/modules/editable-grid-layout/injectables/widgets-positions-state.service.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.