SED-4373 Refactor split view in plan's editor#1289
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PlanSourceDialogComponent, | ||
| PlanNodesDragPreviewComponent, | ||
| ArtefactDropInfoPipe, | ||
| KeywordDropInfoPipe, | ||
| PlanDropInfoPipe, | ||
| ], | ||
| imports: [StepCommonModule, ExecutionModule], | ||
| imports: [StepCommonModule, ExecutionModule, PlanNodesDragPreviewComponent, PlanControlsComponent], |
There was a problem hiding this comment.
PlanEditorModule now pulls PlanNodesDragPreviewComponent and PlanControlsComponent into the imports array, but both components (and the Plan* list components/pipes they import) are defined with imports but without standalone: true and are no longer declared in any NgModule. Angular refuses to import non-standalone declarables, so the plan editor module will fail to compile with errors like “Component … is not standalone and cannot be imported.” These components need to be marked standalone or added back to a module’s declarations.
Useful? React with 👍 / 👎.
| @Component({ | ||
| selector: 'step-split', | ||
| templateUrl: './split.component.html', | ||
| styleUrls: ['./split.component.scss'], | ||
| imports: [SplitResizableAreaComponent, SplitFoldableAreaComponent, NgTemplateOutlet, SplitGutterComponent], |
There was a problem hiding this comment.
SplitComponent imports SplitResizableAreaComponent, SplitFoldableAreaComponent, and SplitGutterComponent, but those subcomponents are neither declared in any NgModule nor marked standalone: true. Importing non-standalone components in another component’s imports array will cause Angular compilation to fail (“… is not standalone and cannot be imported”), so the split layout cannot render after this change. The subcomponents need to be made standalone or declared in a module before being imported here.
Useful? React with 👍 / 👎.
1 participant
No description provided.