Update pulsar-install.sh to ensure proper quoting on _release_url variable#367
Open
jlorich wants to merge 1 commit intoexein-io:mainfrom
Open
Update pulsar-install.sh to ensure proper quoting on _release_url variable#367jlorich wants to merge 1 commit intoexein-io:mainfrom
jlorich wants to merge 1 commit intoexein-io:mainfrom
Conversation
Member
|
I fixed clippy warnings in another PR, can you rebase this branch? |
Update the release URL variable to be quoted so it works more consistently across different shells and operating systems. On an older Ubuntu 20.04 machine running bash, this line would previously produce the following error: `sh: 103: local: https://api.github.com/repos/exein-io/pulsar/tarball/v0.9.0: bad variable name`
banditopazzo
requested changes
Oct 17, 2025
|
|
||
| # Download release archive | ||
| local _release_url=$(curl -s https://api.github.com/repos/exein-io/pulsar/releases/tags/${PULSAR_VERSION} | grep "tarball_url" | cut -d : -f 2,3 | tr -d , | tr -d \") | ||
| local _release_url="$(curl -s https://api.github.com/repos/exein-io/pulsar/releases/tags/${PULSAR_VERSION} | grep "tarball_url" | cut -d : -f 2,3 | tr -d , | tr -d \")" |
Member
There was a problem hiding this comment.
quoting doesn't trim a leading whitespace:
❯ export PULSAR_VERSION=v0.9.0
~
❯ export url="$(curl -s https://api.github.com/repos/exein-io/pulsar/releases/tags/${PULSAR_VERSION} | grep "tarball_url" | cut -d : -f 2,3 | tr -d , | tr -d \")"
~
❯ printf '%s\n' "$url"
https://api.github.com/repos/exein-io/pulsar/tarball/v0.9.0
~
❯ please note the leading whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure proper quoting on _release_url variable
Updated the release URL variable to be quoted so it works more consistently across different shells and operating systems. On an older Ubuntu 20.04 machine this line would previously produce the following error:
sh: 103: local: https://api.github.com/repos/exein-io/pulsar/tarball/v0.9.0: bad variable nameI have