Skip to content

Disable GPIO pull when Pin.PULL_NONE #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zrezke wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

Disable GPIO pull when Pin.PULL_NONE #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f876d0
Disable GPIO pull when Pin.PULL_NONE
zrezke Jul 10, 2023
26c5b5a
Require input pin when disabling gpio pull
zrezke Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firmware/source/interfaces/Gpio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ CmdStatus Gpio::initPin(uint8_t const *cmd) {
gpio_pull_up(gp);
} else if(dir == GPIO_IN && cmd[3] == 2) {
gpio_pull_down(gp);
} else if (dir == GPIO_IN) {
gpio_disable_pulls(gp);
}
//a voir gpio_set_outover(gpio, GPIO_OVERRIDE_INVERT);
return CmdStatus::OK;
Expand Down