Skip to content

Add worker to form #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gingerchew wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add worker to form #38

gingerchew wants to merge 6 commits into from

Conversation

@gingerchew
Copy link
Member

@gingerchew gingerchew commented Oct 21, 2020

adds worker into the form object instead of into an array in the global scope

goal here is to keep the global scope completely clean if at all possible, exposing debug methods elsewhere

@gingerchew
adds form back to event interface
357fd16 
needed for part of pubsub wrapper
@gingerchew
uses form object to store worker
8c52848 
cleans up the global scope, and also makes things
a little less wonky IMO
@gingerchew
extracted hashing functions to a module
649f78d
@gingerchew
separated hashing functions to own file
d3c088d
@gingerchew
fixes worker import to work with changes to hashing file
0753399 
Since the prototype method was used, I had to transfer all the prototype
methods over as well. This was a little funky and
quite honestly... I don't like it

But it works
@gingerchew gingerchew added this to the 2.0 milestone Oct 21, 2020
@gingerchew gingerchew linked an issue Oct 21, 2020 that may be closed by this pull request
Firefox bug: Workers are destroyed before function is completed #36
Open
@gingerchew gingerchew mentioned this pull request Oct 21, 2020
Open
@gingerchew gingerchew marked this pull request as ready for review October 21, 2020 18:23
@gingerchew gingerchew added enhancement New feature or request needs testing labels Oct 21, 2020
@gingerchew
Copy link
Member Author

gingerchew commented Oct 21, 2020 •
edited
Loading

Testing needed on Firefox:
Bug happens as follows -

  • Worker is created
  • Worker begins verification process
  • Before verification can be completed, the Worker is cleaned up by the Garbage Collector

Confirmed working on Chrome

Testing:

  • Test each page inside of test folder on Firefox
  • Test each page inside of test folder on Safari
  • Test each page inside of test folder on Safari iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request needs testing

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Firefox bug: Workers are destroyed before function is completed

2 participants

@gingerchew