Open
Conversation
added 3 commits
February 24, 2012 16:07
…vel, when starting data is defined
Author
|
@exavolt you still supporting this project? |
Owner
|
@jodoglevy Ah. Yes. Sorry for the late response. Got occupied by other projects. I'll review the request tomorrow. |
Author
|
@exavolt I think the pull request you merged from @adamgreig fixes the additionalProperties issue I was trying to fix in this pull request. So you may not need that anymore (although I did not test to see if his code works for my helloworld test file included in the commits). But confirm on delete would still be useful considering hitting 'enter' when focused in an array currently deletes the current index that has focus (which I'm not sure is what it is meant to do), without prompt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a confirm box before deletions, and allows additionalProperties to correctly show up when the starting data is passed into renderObject has additionalProperties, and the schema contains additionalProperties.
Also adds a new helloworld html file demonstrating the new changes, specifically onde working with starting data containing additionalProperties.