#1336: Changed Bazel module #586
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b7263b.
2. Fixed hard coded paths in exascript_python_wrap.py and javacontainer_impl.cc
tkilias
reviewed
Jan 5, 2026
|
|
||
| stringstream ss; | ||
| m_exaJavaPath = "/exaudf/base/javacontainer"; // TODO hardcoded path | ||
| m_exaJavaPath = "/exaudf/external/exaudfclient_base+/javacontainer"; // TODO hardcoded path |
Collaborator
There was a problem hiding this comment.
Should we extend the comment to explain the external
| sys.path.append(path_to_pyexadataframe) | ||
| else: | ||
| path_to_pyexadataframe="/exaudf/base/python/python3" | ||
| path_to_pyexadataframe="/exaudf/external/exaudfclient_base+/python/python3" |
Collaborator
There was a problem hiding this comment.
We probably should add a comment where this path comes from
tkilias
reviewed
Jan 7, 2026
|
|
||
| include("//base:base.MODULE.bazel") | ||
| bazel_dep(name = "exaudfclient_base", version = "1.0.0") | ||
| local_path_override(module_name="exaudfclient_base", path="base") |
Collaborator
There was a problem hiding this comment.
Should we maybe add a comment, why we use local overwrite here. And, that it later can be replaced by http override or git override, when repositories are split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.