Skip to content

new PR to test on #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
exadmin wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

new PR to test on #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b76a6b5
Refactor isPathFullyIgnored method using streams
exadmin Nov 25, 2025
deb86b9
Add comment for equals method override
exadmin Nov 25, 2025
0d56d71
Merge pull request #10 from exadmin/main
exadmin Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/main/java/com/github/exadmin/sourcesscanner/exclude/ExcludeFileModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,9 @@ public void doSortBeforeSaving() {
}

public boolean isPathFullyIgnored(String relFileOrDirNameHash) {
for (ExcludeSignatureItem next : signatures) {
if (next.getFileHash().equals(relFileOrDirNameHash) && next.getTextHash().equals(SKIP_FULL_FILE_HASH)) return true;
}
return signatures.stream()
.anyMatch(item -> item.getFileHash().equals(relFileOrDirNameHash)
Copy link
Owner Author

@exadmin exadmin Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method chain formatting could be improved for better readability.

Suggested change
.anyMatch(item -> item.getFileHash().equals(relFileOrDirNameHash)
.anyMatch(item -> item.getFileHash().equals(relFileOrDirNameHash)
&& item.getTextHash().equals(SKIP_FULL_FILE_HASH));

#deepseek-review:inline

&& item.getTextHash().equals(SKIP_FULL_FILE_HASH));
}

return false;
}

}
}
3 changes: 3 additions & 0 deletions src/main/java/com/github/exadmin/sourcesscanner/exclude/ExcludeSignatureItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ public void setFileHash(String fileHash) {
this.fileHash = fileHash;
}

/**
* Override equals method for the ExcludeSegnatureItem-class
Copy link
Owner Author

@exadmin exadmin Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in class name in comment - should be 'ExcludeSignatureItem'

Suggested change
* Override equals method for the ExcludeSegnatureItem-class
* Override equals method for the ExcludeSignatureItem-class

#deepseek-review:inline

**/
@Override
public boolean equals(Object o) {
if (o == null || getClass() != o.getClass()) return false;
Copy link
Owner Author

@exadmin exadmin Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use instanceof pattern matching for cleaner null and type checking

Suggested change
if (o == null || getClass() != o.getClass()) return false;
if (!(o instanceof ExcludeSignatureItem other)) return false;

#deepseek-review:inline

Expand Down