[itstool] 2.0.7.r2.g19f9580-1: Migrate to lxml, misc clean up #6387
+1,858
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove patch 0001-Fix-the-crash-from-912099.patch since the issue affects Python 2 only. Link: itstool/itstool#25 Link: https://gitlab.gnome.org/GNOME/gnome-user-docs/-/issues/23
The testsuite must be run manually through tests/run_tests.py, and the check target in Makefile is in fact a nop.
libxml2 has deprecated their Python binding, and makes it really hard to build without cycle. Luckily we have an upstream pull request which migrates itstool to use lxml. Apply it to migrate the only and last user of libxml2's Python binding in eweOS. We must build from the last commit to avoid conflicts. Link: itstool/itstool#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.