Open
Conversation
Owner
|
Generally the addition of an alternative hash function isn't currently something that is planned for this library, as it is intended to be compatible between implementations with minimal fuss. I'll look into available implementations of siphash for the python counterpart https://github.com/ewdurbin/clandestined-python, as well as the overall characteristics of the algorithms as they suit the intentions of this library. In the meantime, it seems that all travis checks failed for this PR across all versions. Would you mind taking a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use siphash for its short input characteristics. This PR includes support and tests for SipHash. Please let me know what you think!