Skip to content

labs: Rework random rectangle generation #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliaogris merged 3 commits into from
Feb 8, 2025
Merged

labs: Rework random rectangle generation #462

juliaogris merged 3 commits into from
Feb 8, 2025

Conversation

@juliaogris
Copy link
Member

@juliaogris juliaogris commented Feb 7, 2025 •
edited
Loading

Rework random rectangle generation to avoid rounding differences on Mac and
Linux. This is not going to the bottom of the problem, just making the build
pass again on mac for now.

Additionally a vulnerability has been found by govulncheck in the crypto stdlib.
An upgrade with hermit upgrade go from 1.23.5 to 1.23.6 fixes the build.

@github-actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

firebase-deployment for 6f2a675

@juliaogris juliaogris changed the title wip labs: Rework random rectangle generation Feb 8, 2025
@juliaogris juliaogris marked this pull request as ready for review February 8, 2025 00:37
@juliaogris juliaogris requested a review from camh- as a code owner February 8, 2025 00:37
camh-
camh- approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥬 LGTM. Would be nice to get to the bottom of how the platform difference causes this problem, but if this is blocking then forge ahead!

@juliaogris
e2e: Add slight pixel tolerance to no-diagonal test
63ce1d4 
Add slight pixel tolerance to no-diagonal test to make test pass again on Mac.
Even regenerating the mac specific screenshots did not resolve this as the
no-dialog.png golden file is used in two instances and must render slightly
differently in each one of them.
@juliaogris
tools: Upgrade go
4d78d74 
Upgrade go to 1.23.6 to fix vulnerability only listed on linux.

	Vulnerability #1: GO-2025-3447
	    Timing sidechannel for P-256 on ppc64le in crypto/internal/nistec
	  More info: https://pkg.go.dev/vuln/GO-2025-3447
	  Standard library
	    Found in: crypto/internal/nistec@go1.23.5
	    Fixed in: crypto/internal/nistec@go1.23.6
	    Platforms: ppc64le
	    Example traces found:
	      #1: pkg/cli/runtime.go:89:21: cli.Platform.Cls calls exec.Command, which eventually calls nistec.P256Point.SetBytes

We are not doing a full upgrade because the last one was just merged and I can't
upgrade on mac without first fixing the rounding issue (chicken-egg).
@juliaogris
labs: Rework random rectangle generation
6f2a675 
Rework random rectangle generation to avoid rounding differences on Mac and
Linux. This is not going to the bottom of the problem, just making the build
pass again on mac for now.
@juliaogris juliaogris merged commit 2fda484 into main Feb 8, 2025
4 checks passed
@juliaogris juliaogris deleted the linux-vs-mac branch February 8, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camh- camh- camh- approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliaogris @camh-