Skip to content

Conversation

@josmithua
Copy link

@josmithua josmithua commented Apr 15, 2020

  • Bug fixes
  • Updated IANA tz db to 2019c (latest as of time of PR)
  • Updated list of major cities from wikipedia
  • Updated list of Android timezones
  • Convert code to python3
  • Regenerated zones.h/zones.c using default regions
  • Add another example showing UTC to local time calculation

josmithua and others added 9 commits April 15, 2020 14:14
- Updated IANA tz db to 2019c
- Updated list of major cities from wikipedia
- Updated list of Android timezones
- Convert code to python3
- Updated zones.h/zones.c
- Add more type annotations
- Add docstrings to some functions
- Use f-strings in compile_tzlinks.py
Example shows how to get true local time from UTC time
There is no need to run the example_strip_historical.py script, as the historical data stripping is done  in the `generate_zones.py` script
@evq
Copy link
Owner

evq commented Apr 30, 2020

hey @josmithua! this is awesome, thanks so much for the PR. I will try to review this soon.

I am quite curious about your use case if you can share any information. would it be helpful to start versioning this library? ( e.g. create a branch off master called v0.1 once this is merged in ) I have some small but breaking API changes in another branch that were needed in order to create a rust wrapper.

@josmithua
Copy link
Author

josmithua commented Apr 30, 2020

Hi @evq, glad to be able to contribute. Thanks for creating utz!

We are using utz on our embedded touchscreen device to calculate/display local time based on a user selected time zone, pretty much like the second example that I added (examples/example2.c)

Versioning using semver and creating/tagging releases would be great. Feel free to merge your breaking changes in to a new version. If they're small I'm sure we could merge them into our project easy enough.

@josmithua
Copy link
Author

bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants